-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tg mini apps support #5403
Conversation
# Conflicts: # package-lock.json # providers/ethereum-provider/package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM left minor comments
@@ -17,6 +18,13 @@ export function parseRelayParams(params: any, delimiter = "-"): RelayerTypes.Pro | |||
} | |||
|
|||
export function parseUri(str: string): EngineTypes.UriParameters { | |||
if (!str.includes("wc:")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nit and not sure if it suits this use case but assuming the str
always starts with wc://...
you could also use the URL constructor here and check if the protocol is wc:
Description
Fixed deep links when in telegram mini apps context
formatUriFromPairing
util to regenerate pairing uri from pairing to be used as deeplinkparseUri
util to handle incoming pairing uris in base64 encoding@walletconnect/modal
to latestType of change
How has this been tested?
in telegram mini apps
https://walletconnect.slack.com/archives/C04DB2EAHE3/p1726817747215279
2.16.3-rc-tma-1
Checklist
Additional Information (Optional)
Please include any additional information that may be useful for the reviewer.