[DRAFT][BUGFIX] Fix for sql_mode=only_full_group_by #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much. I will check this and merge it. |
sypets
force-pushed
the
sypets/fix-for-only_full_group_by
branch
from
51bc260
to
0d72e93
Compare
|
It is not finished. I removed the ordering entirely. The order should be changed to 'char'. Sorry about that. (I initially replaced the Extbase query entirely with QueryBuilder and then changed that back. That's when I forgot to handle the sorting as well.) |
|
Just replacing the current order with 'char' resulted in an exception. So, it's a little challenge to get this to work, at least for me currently. I added another PR #12 as an alternative. This will not work for 8.7 (I think) because of the way the language was retrieved. |
sypets
changed the title
In newer MySQL versions the query in GlossaryRepository::findAllForIndex() will fail if sql_mode contains only_full_group_by. The problem is the ORDER BY clause which does not match the GROUP BY. Resolves: WapplerSystems#10
sypets
force-pushed
the
sypets/fix-for-only_full_group_by
branch
from
0d72e93
to
5feeea6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In newer MySQL versions the query in GlossaryRepository::findAllForIndex()
will fail if sql_mode contains only_full_group_by.
The problem is the ORDER BY clause which does not match the GROUP BY.
Resolves: #10