updatemanager: Close file on failure

Warzone2100 · Sep 11, 2024 · 02e0b02 · 02e0b02
1 parent fcb7978
commit 02e0b02
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/updatemanager.cpp b/src/updatemanager.cpp
@@ -735,12 +735,14 @@ static bool cacheInfoIsUsable(CachePaths& paths)
 			if (filesize <= 0)
 			{
 				// Invalid file size
+				PHYSFS_close(fileHandle);
 				throw std::runtime_error("Invalid filesize");
 			}
 			std::vector<char> fileData(static_cast<size_t>(filesize + 1), '\0');
 			if (WZ_PHYSFS_readBytes(fileHandle, fileData.data(), static_cast<PHYSFS_uint32>(filesize)) != filesize)
 			{
 				// Read failed
+				PHYSFS_close(fileHandle);
 				throw std::runtime_error("Read failed");
 			}
 			PHYSFS_close(fileHandle);
@@ -791,12 +793,14 @@ static void initProcessData(const std::vector<std::string> &updateDataUrls, Proc
 			if (filesize < 0 || filesize > WZ_UPDATES_JSON_MAX_SIZE)
 			{
 				// Invalid file size
+				PHYSFS_close(fileHandle);
 				throw std::runtime_error("Invalid filesize");
 			}
 			std::vector<char> fileData(static_cast<size_t>(filesize + 1), '\0');
 			if (WZ_PHYSFS_readBytes(fileHandle, fileData.data(), static_cast<PHYSFS_uint32>(filesize)) != filesize)
 			{
 				// Read failed
+				PHYSFS_close(fileHandle);
 				throw std::runtime_error("Read failed");
 			}
 			PHYSFS_close(fileHandle);