Simplify, fix code typos in docs.

Washi1337 · Mar 15, 2023 · c64a899 · c64a899
1 parent e839a83
commit c64a899
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 10 deletions.
diff --git a/docs/dotnet/type-signatures.rst b/docs/dotnet/type-signatures.rst
@@ -274,15 +274,15 @@ These rules are implemented in AsmResolver using the ``IsCompatibleWith`` and ``
 
 .. code-block:: csharp
 
-    if (comparer.IsCompatibleWith(type1, type2)) 
+    if (type1.IsCompatibleWith(type2)) 
     {
         // type1 can be converted to type2.
     }
 
 
 .. code-block:: csharp
 
-    if (comparer.IsAssignableTo(type1, type2)) 
+    if (type1.IsAssignableTo(type2)) 
     {
         // Values of type1 can be assigned to variables of type2.
     }
diff --git a/src/AsmResolver.DotNet/Signatures/Types/ArrayBaseTypeSignature.cs b/src/AsmResolver.DotNet/Signatures/Types/ArrayBaseTypeSignature.cs
@@ -16,6 +16,9 @@ protected ArrayBaseTypeSignature(TypeSignature baseType)
         {
         }
 
+        /// <inheritdoc />
+        public override bool IsValueType => false;
+
         /// <summary>
         /// Gets the number of dimensions this array defines.
         /// </summary>
@@ -56,8 +59,7 @@ protected override bool IsDirectlyCompatibleWith(TypeSignature other)
             var v = BaseType.GetUnderlyingType();
             var w = elementType.GetUnderlyingType();
 
-            return SignatureComparer.Default.Equals(v.GetReducedType(), w.GetReducedType())
-                   || v.IsCompatibleWith(w);
+            return v.IsCompatibleWith(w);
         }
     }
 }
diff --git a/src/AsmResolver.DotNet/Signatures/Types/ArrayTypeSignature.cs b/src/AsmResolver.DotNet/Signatures/Types/ArrayTypeSignature.cs
@@ -58,9 +58,6 @@ public ArrayTypeSignature(TypeSignature baseType, params ArrayDimension[] dimens
         /// <inheritdoc />
         public override string Name => $"{BaseType.Name ?? NullTypeToString}{GetDimensionsString()}";
 
-        /// <inheritdoc />
-        public override bool IsValueType => false;
-
         /// <summary>
         /// Gets a collection of dimensions.
         /// </summary>

diff --git a/src/AsmResolver.DotNet/Signatures/Types/SzArrayTypeSignature.cs b/src/AsmResolver.DotNet/Signatures/Types/SzArrayTypeSignature.cs
@@ -25,9 +25,6 @@ public SzArrayTypeSignature(TypeSignature baseType)
         /// <inheritdoc />
         public override string Name => $"{BaseType.Name ?? NullTypeToString}[]";
 
-        /// <inheritdoc />
-        public override bool IsValueType => false;
-
         /// <inheritdoc />
         public override int Rank => 1;