Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetHashCode for FunctionPointerTypeSignature is not implemented #551

Closed
BadRyuner opened this issue Apr 16, 2024 · 1 comment
Closed

GetHashCode for FunctionPointerTypeSignature is not implemented #551

BadRyuner opened this issue Apr 16, 2024 · 1 comment
Labels
bug dotnet Issues related to AsmResolver.DotNet
Milestone

Comments

@BadRyuner
Copy link

AsmResolver Version

5.5.1

.NET Version

Any

Operating System

Windows

Describe the Bug

Hashset is not friendly with FunctionPointerTypeSignature
Target site

How To Reproduce

var somemodule = new ModuleDefinition("heh");
var ty = somemodule.CorLibTypeFactory;
HashSet<TypeSignature> hashset = new HashSet<TypeSignature>(SignatureComparer.Default);
var somefnsig = new FunctionPointerTypeSignature(MethodSignature.CreateStatic(ty.Int64));
hashset.Add(somefnsig); // <--- System.NotSupportedException: "Specified method is not supported."

Expected Behavior

Not to see NotSupportedException.

Actual Behavior

We see NotSupportedException.

Additional Context

No response

@BadRyuner BadRyuner added the bug label Apr 16, 2024
@Washi1337 Washi1337 added this to the 6.0.0 milestone Apr 17, 2024
@Washi1337 Washi1337 added the dotnet Issues related to AsmResolver.DotNet label Apr 17, 2024
@Washi1337
Copy link
Owner

Should be fixed on latest commit on the development branch. Thanks for the catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dotnet Issues related to AsmResolver.DotNet
Projects
None yet
Development

No branches or pull requests

2 participants