-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Callbacks implementation for MemberCloner #337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks a lot for writing an implementation and tests!
Few things here and there regarding code style inconsistencies (maybe check .editorconfig
), but I think the main thing that we probably want to consider changing is making all methods virtual
instead of abstract
, and moving the OnClonedXXX
members into the interface. See comments below.
Other than that, lgtm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks a lot. This extension will definitely be useful. 👍
Solves [#333]