-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Parameter.CreateParameterDefinition helper method #418
Merged
Washi1337
merged 9 commits into
Washi1337:development
from
ElektroKill:feature/parameter-qol-improvements
Mar 2, 2023
Merged
Add Parameter.CreateParameterDefinition helper method #418
Washi1337
merged 9 commits into
Washi1337:development
from
ElektroKill:feature/parameter-qol-improvements
Mar 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Washi1337
reviewed
Mar 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, but otherwise LGTM.
We probably also want to add a unit test for the new helper method.
test/AsmResolver.DotNet.Tests/Collections/ParameterCollectionTest.cs
Outdated
Show resolved
Hide resolved
test/AsmResolver.DotNet.Tests/Collections/ParameterCollectionTest.cs
Outdated
Show resolved
Hide resolved
Washi1337
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Parameter
to make the creation ofParameterDefinition
objects easierExplicitThis
flag set to true.