Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release preparation #15

Merged
merged 20 commits into from
Jun 29, 2023
Merged

Conversation

apepkuss
Copy link
Collaborator

In this PR, some required tasks are done for the coming release (Rust SDK 0.9.0):

  • Updated docs and rustdocs
  • Updated release CI workflows
  • Bumped versions

Copy link
Member

juntao commented Jun 29, 2023

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Overall, the set of summaries for the GitHub Pull Request titled "release preparation" indicate several potential issues and errors that need attention:

  1. The use of alpha releases for dependencies (wasmedge-macro, wasmedge-types, rust-sys, async-wasi) raises concerns about stability and compatibility. It is important to review the changes in these alpha versions and ensure they do not introduce any regressions or issues.

  2. The reasons for updating to alpha releases are not clearly documented in the commit messages or Pull Request description. It is important to provide context and justification for the version updates.

  3. The lack of information on compatibility checks with the new versions and thorough testing before the release is concerning. It is advisable to verify that all dependencies are compatible and perform comprehensive testing to avoid introducing bugs or regressions.

  4. The patch descriptions lack details on any potential breaking changes or deprecations introduced in the new versions. It would be helpful to have a clear analysis of how the version bumps might affect existing functionality and if any changes are required in downstream projects.

  5. The patch descriptions in some cases lack sufficient context and information about the purpose and impact of the changes. It is important to provide more details, especially for updates to dependencies or the SDK.

Addressing these issues and ensuring a thorough review, compatibility checks, and testing process will help to prepare a robust release.

Details

Commit 28f54ab6a1ec39d11cf3d6fa572d9f5a6bc4eca9

Key changes:

  • The version of the crate "wasmedge-types" is being bumped from "0.4.2" to "0.4.2-alpha.1" in the Cargo.toml file.

Potential problems:

  • None apparent.

Overall, this patch modifies the version of the "wasmedge-types" crate. It seems to be a preparation for a release, as indicated by the commit message. This change should be compatible with the existing codebase and should not introduce any problems.

Commit 221df6b517a5f99bee8a5c2bb4f0de5dba1050a5

Key Changes:

  • Version of the async-wasi crate is bumped from 0.0.1 to 0.0.1-alpha.1 in the Cargo.toml file.

Potential Problems:

  • None

Overall, this patch only updates the version of the async-wasi crate and does not introduce any potential problems.

Commit 79b4518438c7a997c9d889991ca933b4e172d9f5

Key changes in the patch:

  • The version of the wasmedge-macro crate in Cargo.toml has been bumped from 0.4.0 to 0.4.0-alpha.1.

Potential problems:

  • It is unclear why the version is being bumped to an alpha release (0.4.0-alpha.1). Alpha releases are typically used for initial testing and not recommended for production use. This should be confirmed and justified.
  • It would be helpful to have more information in the commit message about why this specific version bump is being made.

Other observations:

  • No other significant changes are present in the patch.

Commit 66486ea9c65f45ac0e788f1e17ab78ca978b39df

Key changes:

  • The version of the rust-sys crate has been bumped from 0.14.0 to 0.14.0-alpha.1.
  • The version field in Cargo.toml has been updated accordingly.

Potential problems:

  • The new version of rust-sys is an alpha release, which means it may not be stable or fully tested yet. This could introduce bugs or compatibility issues.
  • It's unclear why the version has been changed to an alpha release. The reason should be documented in the commit message or in the Pull Request description for clarity.

Overall, the changes seem to be a preparation for a new release, but the use of an alpha version could introduce potential issues.

Commit 2b6a56960c05d87cc20619d2f25ac741bde38e44

Key changes:

  • The version of the rust-sdk is being bumped to 0.9.0-alpha.1.

Potential problems:

  • It is not clear from the patch description why this version bump is being made or what changes are included in this release. It would be helpful to have more information on the reasons behind this version update and any important changes or bug fixes included.
  • It is unclear if the dependencies have been checked to ensure compatibility with the new version. It would be advisable to verify that all dependencies are compatible and update them if necessary.
  • There is no information on any testing that has been done to ensure the new version works as expected. It is important to include thorough testing before releasing a new version to avoid introducing bugs or regressions.
  • The patch description lacks details on any potential breaking changes or deprecations introduced in this version. It would be helpful to have a clear analysis of how this version bump might affect existing functionality and if any changes are required in downstream projects.

Overall, more information and context should be provided in the pull request to ensure that reviewers have a complete understanding of the changes and can make an informed assessment.

Commit 519b6685194123d4141749471b080f9018a3e2e8

Key changes:

  • The WASMEDGE_RELEASE_VERSION constant in the wasmedge-sys/build.rs file has been updated from "0.12.1" to "0.13.0-alpha.1".

Potential problems:

  • The new value for WASMEDGE_RELEASE_VERSION is "0.13.0-alpha.1". This suggests that it is an alpha version, which means it might not be stable or production-ready yet. This should be taken into consideration when preparing for a release.

Overall, the patch seems to be a simple update to the WASMEDGE_RELEASE_VERSION constant.

Commit 54de450a8f480bb78c815c16495834bbe25eaa06

Key Changes:

  • The dependencies for wasmedge-macro and wasmedge-types have been updated to specific versions (0.4.0-alpha.1 and 0.4.2-alpha.1 respectively).
  • The dependency for async-wasi has been updated to version 0.0.1-alpha.1.

Potential Problems:

  • The new versions of wasmedge-macro, wasmedge-types, and async-wasi are specified as alpha releases. This means they may not be stable and could introduce breaking changes or bugs.
  • It is unclear why the versions have specifically been updated to these alpha releases, and whether they have been thoroughly tested.

Overall, the key changes seem to be updating dependencies, but the use of alpha releases raises concerns about stability and compatibility. It would be advisable to review the changes in the alpha versions and ensure they do not introduce any regressions or issues. Additionally, it would be useful to understand the rationale behind updating to these specific versions.

Commit e619a6d1b3bc62f2a51cf0c4c700054d4689e18d

Key changes:

  • Updated dependencies for wasmedge-macro from version 0.4 to 0.4.0-alpha.1.
  • Updated dependencies for wasmedge-sys from version 0.14 to 0.14.0-alpha.1. Also, set default-features to false.
  • Updated dependencies for wasmedge-types from version 0.4 to 0.4.2-alpha.1.

Potential problems:

  • There are no potential problems identified in this patch. The changes seem to be updating the dependencies to newer versions or alpha versions which may include bug fixes or new features. However, it is always recommended to test the changes thoroughly to ensure compatibility and functionality.

Overall, the changes in this patch seem to be standard dependency updates.

Commit 1cf84b462dd5a4c6e3b429ae14298c81f21e3c95

Key changes in the patch:

  1. Added a wasmedge --version command after running tests for the standalone workflow on Ubuntu, Fedora, macOS, and Windows.

Potential problems:

  1. There are no potential problems identified in this patch. However, without more context or information about the project, it is difficult to determine if these changes are appropriate or necessary.

Commit b4aab9137fc1bb54575eeb5f192c0961241f0966

Key Changes:

  • The dependency syn in the wasmedge-macro crate has been updated from version 2.0.18 to version 2.

Potential Problems:

  • It is difficult to identify any potential problems by just looking at this patch. However, updating dependencies can sometimes introduce compatibility issues or bugs. It would be important to thoroughly test the code after this update to ensure that everything is still functioning as expected.

Commit 4fa5eb6b6a8b09d6bcb90033490f491d3174ada4

Summary of key changes:

  • Bumped the version of the async-wasi crate from 0.0.1-alpha.1 to 0.0.1.

Potential problems:

  • No potential problems were identified in this patch.

Overall, this patch is a simple version bump for the async-wasi crate.

Commit cf0a7defe8855d3a5557472c3c4bf56d384aff8f

Key changes:

  • Bumped the version of wasmedge-macro crate from 0.4.0-alpha.1 to 0.4.0 in Cargo.toml.
  • Updated the patch author's email in the signed-off-by field.

Potential problems:

  • There don't seem to be any obvious issues with this patch. However, it would be helpful to have more context about the purpose of this change and its impact on the project.

Commit 95b72832011c5ad9d00559d252b14048fc62bda8

Key changes:

  • Update the crate "wasmedge-types" to version "0.4.2".
  • Update the dependency "thiserror" to version "1.0.30".

Potential problems:

  • No potential problems have been identified based on the provided patch.

Commit f2880ba202fe520632994a56a3e076174fc8bd61

Key Changes:

  • Bumped the version of the wasmedge-sys crate from 0.14.0-alpha.1 to 0.14.0
  • Updated the dependencies wasmedge-macro and wasmedge-types to version 0.4
  • Updated the dependencies async-wasi to version 0.0.1

Potential Problems:

  • The bumped version of wasmedge-sys may introduce breaking changes or incompatible changes that could affect the functionality of the codebase.
  • The update of dependencies wasmedge-macro and wasmedge-types may also introduce breaking changes or compatibility issues that need to be investigated.
  • The update of async-wasi to version 0.0.1 may introduce breaking changes or compatibility issues.

Overall, it is important to carefully review the changes in the codebase, ensuring that the new versions of the dependencies are compatible and any potential issues are addressed.

Commit 5a47f76a0c1a9bf399aa68a79e574cd27313ba56

Key changes:

  • The Rust SDK version has been bumped from "0.9.0-alpha.1" to "0.9.0".
  • The versions of the dependencies wasmedge-macro, wasmedge-sys, and wasmedge-types have also been bumped.

The most important findings are:

  1. The Rust SDK version has been updated to "0.9.0". It is important to check the release notes of this version to understand the impact on the codebase and any potential breaking changes.

Potential problems:

  • The patch does not include any specific changes made to the code. It only includes updates to the version numbers of dependencies and the SDK itself. Without more information, it is difficult to identify potential problems in the code.

Recommendation:

  • Request more information from the contributor about the specific changes made in this pull request and any potential issues that should be addressed.

Commit 2082a7802b18aa5360be3f8e5b8f7cc51ab5ded8

Key Changes:

  • Added #[doc(hidden)] attribute to the sys_host_function and sys_async_host_function macros.

Potential Problems:

  • No potential problems were identified in this patch.

Commit 8192f187b697e1313f7ed9a37a354dde02b5c0a6

Key changes in the patch:

  • The patch updates the documentation comments in the lib.rs file.
  • It adds new information about the required version of the WasmEdge library for each version of the wasmedge-sdk crate.
  • It adds a new type alias NeverType for the NeverType from wasmedge_types crate.
  • It adds a new type alias CallingFrame for the wasmedge_sys::CallingFrame.
  • It adds new types and aliases related to the async feature on the Linux OS.

Potential problems:

  • There don't appear to be any significant problems in this patch. However, it would be helpful to update the documentation with more specific information about the changes made in this patch and provide examples of how to use the new types and aliases.

Commit 1cecc2809afa594d01be74131aa3ca2642e3e4ba

Key changes:

  1. Added comments documenting the signature of asynchronous host functions and host functions.
  2. Added a comment documenting AsyncWasiModule as a module instance for the WASI specification used in the async scenario.
  3. Added a comment documenting WasiCtx as the type of wasi context used to configure the wasi environment.

Potential problems:

  1. No potential problems were identified in this patch. The changes seem to be related to adding comments to improve code documentation.

Overall, this patch seems to be a documentation improvement and does not introduce any functional changes or issues.

Commit 6d1870fc12d3d5026a87b4d4764f83a2b5b894ed

Key changes:

  • The file .github/workflows/bindings-rust.yml has been renamed to test.yml.
  • The name of the workflow has been changed from "binding-rust" to "Continuous integration".
  • The push event trigger for the workflow is no longer restricted to specific branches like main, feat/*, etc.

Potential problems:

  • It seems that the trigger for the workflow has been modified and no longer filters branches or paths. This means that the workflow will now be triggered for any repository push and file changes, which may not be intended. It should be reviewed to ensure that the new trigger configuration aligns with the desired behavior.

Other observations:

  • The commit message and the patch itself do not provide much context on why these changes were made or the rationale behind them. Some additional information or a more descriptive commit message could help in understanding the purpose of the changes.

Commit 95bc9a48ec53bc7420eb20a95998720736cd039c

Key Changes:

  • The build_fedora job in the standalone.yml GitHub workflow has been updated.
  • The name of the job has been changed from "Fedora latest" to "Fedora".
  • The "runs-on" value has been changed from "Fedora-latest" to "ubuntu-latest".
  • The rust versions in the matrix have been updated to include 1.70.0, 1.69, and 1.68.

Potential Problems:

  • It seems that the name of the job has been updated, but it is not clear why "Fedora latest" was changed to just "Fedora". This change could potentially cause confusion.
  • The "runs-on" value has been changed from "Fedora-latest" to "ubuntu-latest". This might be intentional, but it could introduce compatibility or environment issues depending on the specific requirements of the job.
  • The rust versions in the matrix have been updated. It is unclear if this change was necessary or if it could cause compatibility or build issues.

Other Observations:

  • No other significant changes or problems were identified in this patch.

@apepkuss
Copy link
Collaborator Author

@L-jasmine Thanks for the review!

@apepkuss apepkuss merged commit 0f436d2 into WasmEdge:main Jun 29, 2023
@apepkuss apepkuss deleted the test/release-0.9.0-alpha.1 branch June 29, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants