-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for standalone static libraries #22
Conversation
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Overall Summary: The pull request adds support for standalone static libraries and fixes Clippy issues introduced with a new nightly version. There are potential problems that need to be addressed, including unclear conditional compilation directives, unused extracted files, strange syntax for variable interpolation, and platform dependency on invoking the DetailsCommit 68dbfb6da0f850f530ace2186caac787af02c52cKey changes:
Potential problems:
Overall, the changes need further clarification and testing. The review of this patch should focus on resolving these issues and ensuring that the implementation of support for standalone static libraries is correct and robust. Commit 12b6397a72a1c83994cb937fcbd22fe733bb7d18Key Changes:
Potential Problems:
|
Hi @apepkuss |
Signed-off-by: Jorge Prendes <[email protected]>
f8a8817
to
68dbfb6
Compare
@jprendes Please check the results of the CI workflows to fix the Clippy issues. Thanks! |
@jprendes You can ignore the failure of the CI workflow for Windows. |
Looks like the clippy issues were intruduced by a new nighly version of clippy. |
Signed-off-by: Jorge Prendes <[email protected]>
dec08a3
to
12b6397
Compare
@jprendes There are still some failures in the CI workflows, but they are not caused by this PR. We'll fix them in another PR. So I'll approve this PR first. Thanks a lot! |
WasmEdge started releasing static libraries WasmEdge/WasmEdge#2660
The
wasmedge-sys
crate support astandalone
feature when using shared libraries.This PR adds support for the
standalone
feature with static libraries.