-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Update proc-macros in wasmedge-macro
#49
[Refactor] Update proc-macros in wasmedge-macro
#49
Conversation
…` proc-macros Signed-off-by: Xin Liu <[email protected]>
Signed-off-by: Xin Liu <[email protected]>
Signed-off-by: Xin Liu <[email protected]>
Signed-off-by: Xin Liu <[email protected]>
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Overall Summary: In general, the pull request titled "[Refactor] Update proc-macros in The first set of changes focuses on refactoring the The second set of changes updates the version of The third set of changes adds a new API The final set of changes bumps the version of To summarize, the refactoring changes in the first set have potential issues and errors that should be addressed. The other sets of changes seem fine without any identified problems. DetailsCommit 7d13b92fb30a86cf79cdc45b67f41504097a6a4fKey changes:
Potential problems:
Commit b693f8807d3ef5f817bcf9a16754b2dcca24b1e0Key Changes:
Potential Problems:
Commit 2a4244099d5074e09f5f8b8c702f7d708fb9a037Key changes:
Potential problems:
Commit c034a9ff9f7b4ec301eaed4524aa7b320324db3aKey changes:
Potential problems:
|
@L-jasmine Thanks for the review! |
In this PR, the
host_function
andasync_host_function
proc-macros inwasmedge-macro
are improved. In addition, introduce a new API namedgenerate
inWasiContext
ofwasmedge-sdk
.