Cleaned up CUDAEnv/Flow.jl and fixed allowscalar in tests. Fixed BCs too. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…U or GPU arrays. It also uses the new apply! with @loop. Fixed allowscalar in tests. According to the docs, this is the correct way to do lines/block allowscalar stuff.
b-fg
changed the title
Cleaned up CUDAEnv/Flow.jl and removed CUDAEnv/bcs.jl, since the latter is already in utils.jl and tested. Added OutMacro.jl package as extra since it is useful for debugging.
These still fail in GPU since L2 function in utils.jl is indexing. Tests for utils.jl are all passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CUDAEnv/Flow.jl now uses the
|>fnotation to create CPU or GPU fields.fshould beidentityfor CPU orcufor GPU.It also uses the new
apply!when creating the structs.I also fixed the
allowscalarnotation in tests, and this should be the recommended way to do so according to the docs.