Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce UMAP rendered notebook size and avoid docsite .doctree files for publishing #94

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Sep 13, 2024

Description

This PR addresses #93 by removing .doctree files before pushing to GitHub Pages. While I investigated this I also reduced the file size of the JUMP UMAP notebook by updating two UMAP output cells to show images rather than dynamic plots.

Closes #93

What kind of change(s) are included?

  • Documentation (changes docs or other related content)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • These changes pass all pre-commit checks.
  • I have added comments to my code to help provide understanding
  • I have added a test which covers the code changes found within this PR
  • I have deleted all non-relevant text in this pull request template.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@d33bs d33bs marked this pull request as ready for review September 13, 2024 19:44
Copy link
Member

@jenna-tomkinson jenna-tomkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@d33bs
Copy link
Member Author

d33bs commented Sep 16, 2024

Thanks @jenna-tomkinson, merging this in!

@d33bs d33bs merged commit 157d5d2 into WayScience:main Sep 16, 2024
9 checks passed
@d33bs d33bs deleted the reduce-umap-rendered-notebook-size branch September 16, 2024 21:32
@d33bs d33bs mentioned this pull request Sep 18, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid publishing doctrees files from Sphinx to prevent errors
2 participants