animate: lock views while cleaning up (#2142)

Ensures that we don't accidentally crash when cleaning up views. Fixes #2005
WayfireWM · Mar 13, 2024 · 38532b4 · 38532b4
1 parent 25eab09
commit 38532b4
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/plugins/animate/animate.cpp b/plugins/animate/animate.cpp
@@ -224,7 +224,13 @@ struct animation_hook : public animation_hook_base
 
 static void cleanup_views_on_output(wf::output_t *output)
 {
+    std::vector<std::shared_ptr<wf::view_interface_t>> all_views;
     for (auto& view : wf::get_core().get_all_views())
+    {
+        all_views.push_back(view->shared_from_this());
+    }
+
+    for (auto& view : all_views)
     {
         auto wo = view->get_output();
         if ((wo != output) && output)