Skip to content

Commit

Permalink
core: emit view decoration updated signal even for unmapped views (#2350
Browse files Browse the repository at this point in the history
)

This fixes problems with views like Steam's dialogs which map and unmap
and change their decoration state in the meantime. Plus, it makes no
sense not to emit the signal.
  • Loading branch information
ammen99 authored May 12, 2024
1 parent 4828088 commit 5b4f9b9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/view/xdg-shell/xdg-toplevel-view.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ void wf::xdg_toplevel_view_t::set_decoration_mode(bool use_csd)
{
bool was_decorated = should_be_decorated();
this->has_client_decoration = use_csd;
if ((was_decorated != should_be_decorated()) && is_mapped())
if (was_decorated != should_be_decorated())
{
wf::view_decoration_state_updated_signal data;
data.view = {this};
Expand Down
2 changes: 1 addition & 1 deletion src/view/xwayland/xwayland-toplevel-view.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ class wayfire_xwayland_view : public wf::toplevel_view_interface_t, public wayfi
{
bool was_decorated = should_be_decorated();
this->has_client_decoration = use_csd;
if ((was_decorated != should_be_decorated()) && is_mapped())
if (was_decorated != should_be_decorated())
{
wf::view_decoration_state_updated_signal data;
data.view = {this};
Expand Down

0 comments on commit 5b4f9b9

Please sign in to comment.