Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement single-pixel-buffer-v1? #1958

Closed
flexibeast opened this issue Oct 16, 2023 · 2 comments · Fixed by #2052
Closed

Implement single-pixel-buffer-v1? #1958

flexibeast opened this issue Oct 16, 2023 · 2 comments · Fixed by #2052
Labels
easy Issues that do not require knowledge about the whole codebase enhancement good first issue

Comments

@flexibeast
Copy link

Recent versions of the shotman screenshot GUI don't work under Wayfire, due to Wayfire not implementing the single-pixel-buffer-v1 interface. The shotman author linked to how this interface was implemented in Sway.

Might Wayfire also implement this interface?

@ammen99
Copy link
Member

ammen99 commented Oct 16, 2023

Wayfire can implement this, but keep in mind that our implementation will be more complex because we do not use the default wlroots renderer. A Wayfire impl would require extending the texture type and writing the appropriate shaders.

@ammen99
Copy link
Member

ammen99 commented Oct 21, 2023

Actually, I looked at the wlroots implementation, this should actually be very easy to add (unlike I thought initially), just the same as Sway (a few lines to set up the protocol). PRs welcome :)

@ammen99 ammen99 added easy Issues that do not require knowledge about the whole codebase good first issue labels Nov 25, 2023
soreau added a commit that referenced this issue Dec 7, 2023
ammen99 pushed a commit that referenced this issue Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Issues that do not require knowledge about the whole codebase enhancement good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants