Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transactions API #1217

Closed
wants to merge 26 commits into from
Closed

Transactions API #1217

wants to merge 26 commits into from

Conversation

ammen99
Copy link
Member

@ammen99 ammen99 commented Jun 16, 2021 •
edited
Loading

Work-in-progress PR, probably won't be ready for testing in the next few weeks.

Plan:

  • Add abstraction for the wayland event loop, so that idle callbacks and timeouts can be unit-tested
  • Mock wf::core_interface_t and implementation.
  • Add a wrapper around wlroots commit locking functionality.
  • Make view map/unmap happen via a transaction.
  • Add basic transactions infrastructure for setting maximized/fullscreen states
  • Add window size
    • Compositor-initiated resize
    • Client disobeying compositor request
    • Client-initiated resize
  • Add setting output via transactions maybe in a follow-up PR
  • Use transactions for switching workspaces
  • Add moving/resizing state to views
  • Make grid animate any geometry change aside for moving/resizing views
  • Make simple tile use transactions instead of enforcing geometry
  • Make transaction timeouts configurable
  • Unit tests:
    • Regular transaction
    • Transaction which times out
    • Aggregation of pending transactions
    • Concurrent transactions
    • Transaction which is cancelled.

@ammen99 ammen99 force-pushed the transactions branch 3 times, most recently from b5dc4f5 to 02e4270 Compare June 23, 2021 18:37
@ammen99 ammen99 force-pushed the transactions branch 2 times, most recently from 8b22aa6 to e0b1012 Compare July 18, 2021 13:45
@ammen99 ammen99 force-pushed the transactions branch 2 times, most recently from f11f314 to 48864fa Compare August 1, 2021 07:54
@ammen99 ammen99 mentioned this pull request Aug 20, 2021
Closed
@ammen99 ammen99 mentioned this pull request Oct 12, 2021
Merged
@ammen99
view: add wrapper for wlr surface locking
a40f28b
@ammen99
view: add state() method
500980b
@ammen99
xdg-shell: add surface lock manager
cb57f4d
@ammen99
xdg-shell: unmap with transactions
3536dab
@ammen99
view: make geometry transactional
7f6d694 
Very basic tests work so far.
@ammen99
xdg-shell: more set geometry
3504b41
@ammen99
view: add support for setting window gravity
c0fe8ab
@ammen99
some work on gravity + geometry
6c1d435
@ammen99
api: move surface-lock to the API
7561f80
@ammen99
api: move emit_instruction_signal to public API
c331cd2
@ammen99
core: store mapping of stringified view to view
d73d368
@ammen99
xdg-shell: return correct wlr_surface even if not mapped
367a80a
@ammen99
TEMPORARY COMMIT NOT FOR MASTER!!
9b18d03
@ammen99
api: rename decorator_frame_t_t -> view_decorator_t and improve API
39ac02d
@ammen99
xdg-shell: fix typo
7b19cfc
@ammen99
view: do not generate geometry instructions if they are no-op
ac55a69
@ammen99
xdg-shell: map with a transaction
7fa9208
@ammen99
miserable attempts to send more frame events, needs to be fixed in wlr
8e0b0ab
@ammen99
view: make tiled edges atomic state
d0888f1
@ammen99
api: make view_transaction_t a little more ergonomic for simple uses
dda288b
@ammen99
xdg-shell: cancel transactions if base surface is unmapped
26f3a0d
@ammen99
Copy link
Member Author

ammen99 commented Jun 7, 2023

Closing in favor of #1704

@ammen99 ammen99 closed this Jun 7, 2023
@ammen99 ammen99 deleted the transactions branch June 7, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ammen99