ipc-rules: change output from name to ID. #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The idea is good, but why not just add a new output-id field, this way this is not a breaking change? |
This is useful because the other IPCs take IDs and not names.
lcolitti
force-pushed
the
list-views-output-id
branch
from
e2f754e
to
e87bc7c
Compare
|
Done. Though technically I anyone using this will have to change their code already, since until a couple of weeks ago list_views was in the stipc plugin and now it's in ipc-rules. |
|
stipc is for tests only, I do not count it in the public API :) |
ammen99
pushed a commit
that referenced
this pull request
Mar 13, 2024
This is useful because the other IPCs take IDs and not names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more useful because the other IPCs take IDs and not names.
For backwards compatibility, also include the output name in an "output-name" member.