Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen to tiled signal in deco plugin and emit view_tiled signal on core #2062

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

timgott
Copy link
Contributor

@timgott timgott commented Dec 11, 2023

Fixes timgott/wayfire-shadows#19 and partially #2043

For the decoration plugin that should be very low overhead even if the maximized criterion is not used, so why not.

But please, can all view signals be consistently emitted on view, output and core at once.

and fire tiled signal on core
@soreau
Copy link
Member

soreau commented Dec 11, 2023

But please, can all view signals be consistently emitted on view, output and core at once.

👍

I've run into problems like this before, builds fine, plugin source hasn't changed but wayfire did, so it doesn't work.

@timgott
Copy link
Contributor Author

timgott commented Dec 11, 2023

So I had only tested with "floating is false", this fixes #2043 only partially, see there.

@ammen99
Copy link
Member

ammen99 commented Dec 20, 2023

But please, can all view signals be consistently emitted on view, output and core at once.

I see no reason not to do it, it may even make sense to have a helper function so that we always emit on all three at once. PRs welcome :)

Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ammen99 ammen99 merged commit b5c0a0b into WayfireWM:master Dec 20, 2023
4 checks passed
mrsteve0924 pushed a commit to mrsteve0924/wayfire that referenced this pull request Mar 2, 2024
ammen99 pushed a commit that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Window Rule not working perfect
3 participants