Implement the session lock protocol, take 2 #2237
Conversation
lcolitti
force-pushed
the
support-session-lock
branch
from
0536ecb
to
243dc2e
Compare
lcolitti
force-pushed
the
support-session-lock
branch
from
0536ecb
to
a972d0b
Compare
plugins/protocols/session-lock.cpp
Outdated
|
|
||
| class backup_node : public simple_text_node_t | ||
| { | ||
| public: |
There was a problem hiding this comment.
This node doesn't have keyboard or pointer interaction set - but it should have it, otherwise, it is not really 'locking' the desktop.
Also on my machine there are a few thin semi-transparent strips along some of the emoji's sides, I am not sure why that happens - I'm mentioning this because through them, I could see that I am clicking on the terminal behind the crashed swaylock :)
There was a problem hiding this comment.
Urg, yes. If I make the backup nodes transparent, it's pretty clear that they're not actually preventing keyboard or mouse input. Fixed in latest patch series (I think) by overriding find_node_at. Not sure if this is correct or whether it will fix touch as well (I don't have a way to test touch).
There was a problem hiding this comment.
Urg, yes. If I make the backup nodes transparent, it's pretty clear that they're not actually preventing keyboard or mouse input. Fixed in latest patch series (I think) by overriding find_node_at. Not sure if this is correct or whether it will fix touch as well (I don't have a way to test touch).
Yes, this is enough to fix touch, tablet and pointer. For the keyboard you'd also have to implement the refocus_keyboard() function very similarly to the lock surface node type.
There was a problem hiding this comment.
Ah, you already have this, nice! I'll test on multi-monitor as well to make sure the logic doesn't break somewhere and merge.
lcolitti
force-pushed
the
support-session-lock
branch
3 times, most recently
from
5b0aefb
to
a1f6665
Compare
These classes are useful and needed by any code that deals with surfaces, because such code usually needs to deal with subsurfaces as well. Move the include files into api/wayfire/unstable so they can be used by code all over the tree, and rename them to reflect the utility classes that they contain.
This will allow lockscreens to be implemented in plugins.
This adds a simple node that can display text.
This will be used by the upcoming implementation of the ext-session-lock protocol.
Currently implemented: - Locking and unlocking. - Display above all desktop layers, including OVERLAY (but below DWIDGET). - Waiting for the client to display locked surfaces before declaring the screen to be locked. If the client does not display all surfaces, locks anyway after a timeout. - Multiple outputs, including outputs being added/removed while locking or locked. - Leaving the screen locked if the client crashes (but allows a new client to come in and lock the screen). TODO: - Deal with outputs being resized. - Properly display text if the screenlocker crashes. Currently it just displays two a big "explosion" emoji. - Use a view instead of a plain wlr_surface_node? Tested with swaylock. Fixes WayfireWM#1494 Fixes WayfireWM#1358
lcolitti
force-pushed
the
support-session-lock
branch
from
a1f6665
to
306dd43
Compare
|
|
Re-applies #2162 (which was reverted) plus addresses more review comments.
Fixes #1494
Fixes #1358