Session lock plugin fixes #2304
Conversation
lcolitti
commented
Apr 2, 2024
lcolitti
commented
- Ensure that if an output is added when the screenlocker has crashed, the new output is locked.
- Support resizing outputs when locked.
- Ensure that if an output is added after the client crashes,
the lock_crashed_node is displayed on that output.
Currently that output would simply be unlocked, oops!
- Create the lock_crashed_node as soon as the output state is
created, instead of when the output is locked.
- When a lock is destroyed, only disconnect the protocol signals,
but leave output add/remove signals connected.
- If a client crashes and the lock enters ZOMBIE state, destroy
it as soon as the next client locks, instead of waiting until
it unlocks. This ensures there is only one lock_crashed_node
per output at any given time.
This is not perfect, because if the output is enlarged some of the screen is visible for a bit until the client updates its surface, but it works well enough for now.
|
Yeah, somehow uncrustify never likes my formatting 🙂. I've added a git
hook that runs it before push so hopefully that won't happen again. Updated.
I considered adding the hook to the repo as well, so other folks can use
it, but the version I have on Debian disagrees with the GitHub version on
how to format one line in one file, and I didn't want to write a hook sync,
compile and run locally.
That said, if you think this could be useful, I can send a PR for it. My
hook is very simple and just ignores the file that doesn't match, and maybe
that's good enough for now.
|
We use a custom fork of uncrustify for formatting because the official one was kinda broken when I last used it. So I think it is not very ideal to make a git commit hook yet. I have considered moving to clang-format at some point, maybe if that happens a git hook would also be a good addition .. |
Ack. FWIW the debian uncrustify only disagrees about this in the whole project:
|
Interesting, maybe they have fixed the bugs I was experiencing, last time I tested was ~2 years ago or so. |
