Move $d_namlen to the end of $dirent #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree it is nicer to keep the name length next to the name data. Would you mind also updating phases/ephemeral/docs.md, either by hand or by running |
|
Done and force pushed 2f64d16 |
|
My apologies, but the patch to land Size and Alignment documentation landed before this, so there's now a merge conflict. Would you mind resolving this? Thanks! |
|
Rebased against current master and ran the doc tool again. |
|
Thanks! |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a minor (although ABI breaking) nit suggestion that stuck out to me when implementing
fd_readdir.Currently
$direnthas the filetype in-between the name length and the name data so you end up scanning the length of entry's name, writing the type of the entry then going back to write out the name data.