Add no-inline IR annotation, and passes to set it based on function name #6146
Conversation
test/lit/help/wasm-opt.test
Outdated
There was a problem hiding this comment.
It would be good to mention that these flags take pattern arguments. Right now the help messages make it sound like they will apply to all functions.
There was a problem hiding this comment.
In general the help texts are short, see e.g. --extract-function which also doesn't mention its argument there. But if you run the pass you get more details:
$ wasm-opt --no-inline a.wat -all
Fatal: Usage usage: wasm-opt --no-inline=WILDCARD
Maybe that's not enough, though?
There was a problem hiding this comment.
Lgtm since it’s consistent and gives more detail when you try to use it.
| } | ||
|
|
||
| // Otherwise, check if we can at least inline part of it, if we are | ||
| // interested in such things. | ||
| if (functionSplitter) { | ||
| if (!func->noPartialInline && functionSplitter) { |
There was a problem hiding this comment.
Partial inlining may also trigger full inline. Should we guard against that when !func->noFullInline?
There was a problem hiding this comment.
Good catch, thanks! Yes, that logic needs to be handled. I fixed that now.
|
It occurred to me that we could make |
…ame (WebAssembly#6146) Any function can now be annotated as not to be inlined fully (normally) or not to be inlined partially. In the future we'll want to read those annotations from the proposed wasm metadata section on code hints, and from wat text as well, but for now add trivial passes that set those fields based on function name wildcards, e.g.: --no-inline=*leave-alone* --inlining That will not inline any function whose name contains "leave-alone" in the name. --no-inline disables all inlining (full or partial) while --no-full-inline and --no-partial-inline affect only full or partial inlining.
Any function can now be annotated as not to be inlined fully (normally) or not to be
inlined partially. In the future we'll want to read those annotations from the proposed
wasm metadata section on code hints, and from wat text as well, but for now add
trivial passes that set those fields based on function name wildcards, e.g.:
That will not inline any function whose name contains "leave-alone" in the name.
--no-inlinedisables all inlining (full or partial) while--no-full-inlineand--no-partial-inlineaffect only full or partial inlining.