-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Move basic tests in lit/ to lit/basic/ #6156
Conversation
Here 'basic' tests means that what we have in binaryen/test/. We checked three things with those tests: - Run `wasm-opt -all -g` on it and compare the output with `*.from-wast` - Run `wasm-as -all -g` and `wasm-dis` on it and compare the output with `*.fromBinary`. - Run `wasm-as -all` and `wasm-dis` on it and compare the output with `*.fromBinary.noDebugInfo`. I plan to move those to `test/lit/`. But `test/lit/` has other kind of tests as well, so I think it'd be nice to have a dedicated directory for these tests. Before doing that, I noticed there are already four tests that have been already ported to do this, and this PR moves them to `test/lit/basic/`. I couldn't come up with a better name than `basic`. If you have other suggestions please let me know.
Moving these to a The CHECK-NODEBUG output appears at the end because the auto-update script doesn't know how to match up the minimal generated names with the human-readable input names. |
Yeah I realized that and deleted the comment but it was too late 😅 ;; RUN: wasm-as %s -all -o %t.wasm
;; RUN: wasm-dis %t.wasm -all -o %t.bin.wast
;; RUN: cat %t.bin.wast | filecheck %s --check-prefix=CHECK
(module
(func $test
(drop
(i32.const 0)
)
)
) Note that there's no |
Do the tests with the missing checks not pass |
Huh, yeah, passing |
Here 'basic' tests means that what we have in `binaryen/test/`. We checked three things with those tests: - Run `wasm-opt -all -g` on it and compare the output with `*.from-wast` - Run `wasm-as -all -g` and `wasm-dis` on it and compare the output with `*.fromBinary`. - Run `wasm-as -all` and `wasm-dis` on it and compare the output with `*.fromBinary.noDebugInfo`. I planned to move those to `test/lit/`. But `test/lit/` has other kind of tests as well, so I think it'd be nice to have a dedicated directory for these tests. Before doing that, I noticed there are already four tests that have been already ported to do this, and this PR moves them to `test/lit/basic/`. I couldn't come up with a better name than `basic`. If you have other suggestions please let me know.
Here 'basic' tests means that what we have in
binaryen/test/
. We check three things with those tests:wasm-opt -all -g
on it and compare the output with*.from-wast
wasm-as -all -g
andwasm-dis
on it and compare the output with*.fromBinary
.wasm-as -all
andwasm-dis
on it and compare the output with*.fromBinary.noDebugInfo
.I planned to move those to
test/lit/
. Buttest/lit/
has other kind of tests as well, so I think it'd be nice to have a dedicated directory for these tests.Before doing that, I noticed there are already four tests that have been already ported to do this, and this PR moves them to
test/lit/basic/
.I couldn't come up with a better name than
basic
. If you have other suggestions please let me know.