[EH] Change translator option name #6259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous name feels too verbose and unwieldy.
aheejin
force-pushed
the
eh_translator_option_change
branch
from
ec7e878
to
140caec
Compare
aheejin
commented
Jan 30, 2024
| @@ -201,10 +200,8 @@ struct TranslateEHOldToNew | |||
| // exnref) tuples for a short time. | |||
| std::unordered_map<Type, Index> typeToScratchLocal; | |||
|
|
|||
| bool refinalize = false; | |||
tlively
approved these changes
Jan 31, 2024
kripken
approved these changes
Jan 31, 2024
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
The previous name feels too verbose and unwieldy. This also removes the "new-to-old EH" placeholder. I think it'd be better to add it back when it is actually added.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous name feels too verbose and unwieldy.
This also removes the "new-to-old EH" placeholder. I think it'd be better to add it back when it is actually added.