Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StringLowering: Modify string=>extern also in public types #6301

Merged
merged 2 commits into from
Feb 13, 2024
Merged

StringLowering: Modify string=>extern also in public types #6301

merged 2 commits into from
Feb 13, 2024

Conversation

kripken
Copy link
Member

@kripken kripken commented Feb 13, 2024

We want to actually remove all stringref appearances, in both public and
private types.

@kripken kripken requested a review from tlively February 13, 2024 19:16
@kripken kripken merged commit cdc9ad9 into WebAssembly:main Feb 13, 2024
14 checks passed
@kripken kripken deleted the string.lowering.exports branch February 13, 2024 20:39
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
@kripken @radekdoulik
StringLowering: Modify string=>extern also in public types (WebAssemb…
c1409f9 
…ly#6301)

We want to actually remove all stringref appearances, in both public and
private types.
@gkdn gkdn mentioned this pull request Aug 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlively tlively tlively approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kripken @tlively