Restrict offsets to index type's range in validation #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yet again I have no idea what is wrong with the PDF build. |
|
Well, the error says it all: |
|
Can you please add tests for this? Otherwise it's easy for engine to overlook this restriction and be like "we pass all tests, hence we fully implement memory64". |
|
Yes, I have a personal todo item to add spec tests for all the recent spec changes. I'll create a GitHub issue today to make that more visible for others though. Thanks for the reminder. |
|
Is this ready to land? |
|
Should be, assuming you're comfortable with tests coming later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds validation of
memarg.offsetto ensure that loads and stores for a 32-bit memory cannot have a 64-bit offset. Execution semantics are unaffected.Resolves #76.