Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm-module-builder: Fix left-over use of kWasmStmt #83

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

backes
Copy link
Member

@backes backes commented Sep 6, 2024

This was renamed to kWasmVoid in 2f5a7c5.

Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something that we could land upstream? (I guess its fine here too since we hope to merge soon.. so lgtm either way).

@sbc100 sbc100 merged commit 615bd1f into WebAssembly:main Sep 23, 2024
1 check passed
@backes backes deleted the fix-memory64-kwasmstmt branch September 24, 2024 11:04
@backes
Copy link
Member Author

backes commented Sep 24, 2024

Is this something that we could land upstream?

For some reason this was only a problem in this repo. Upstream still uses kWasmStmt. This was renamed to kWasmVoid in the exnref repo, and only here we have the left-over use of kWasmStmt. So probably a rebase artifact.

@sbc100
Copy link
Member

sbc100 commented Sep 24, 2024

I believe the issue is present on the upstream wasm-3.0 branch:

$ git grep kWasmStmt origin/wasm-3.0
origin/wasm-3.0:test/js-api/wasm-module-builder.js:        type == kWasmF64 || type == kWasmS128 || type == kWasmStmt) {

And we inherited since we are based on that branch.

@backes
Copy link
Member Author

backes commented Sep 24, 2024

Oh, right, I forgot that the upstream branch is wasm-3.0 and not main.

@rossberg
Copy link
Member

Can I motivate a V8 person to fix this upstream?

@backes
Copy link
Member Author

backes commented Sep 24, 2024

I lost track of which repo or branch is based on which other one, and which branches are irrelevant by now. But if you tell me to fix this in the spec's wasm-3.0 branch, I can do that.

@backes
Copy link
Member Author

backes commented Sep 24, 2024

WebAssembly/spec#1812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants