Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test][js-api] Fix import of table64 and memory64 #84

Merged
merged 2 commits into from
Oct 7, 2024
Merged

[test][js-api] Fix import of table64 and memory64 #84

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe878f3
[test][js-api] Fix import of table64 and memory64
backes Sep 6, 2024
743555d
[test][js-api] Fix import of table64 and memory64
backes Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions interpreter/script/js.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ let spectest = {
global_f32: 666.6,
global_f64: 666.6,
table: new WebAssembly.Table({initial: 10, maximum: 20, element: 'anyfunc'}),
table64: new WebAssembly.Table(
{initial: 10, maximum: 20, element: 'anyfunc', index: 'i64'}),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial and maximum should be BigInts (10n and 20n) now that #75 has been merged. Same for the memory you added below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, that's a change that I still need to do in V8. Thanks for flagging. I'll first add support for BigInt in V8 and then update this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason not to land this now? I was hoping to get some tests added for #75 assuming they could land here and then v8 could pull them in once its is ready?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementing BigInt support in V8 first would allow to test this PR in V8 before landing it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to you here since you are the one doing the work.

However, isn't that backwards from the normal way of doing things. Don't we normally update the spec + spec tests and then update the implementations once those changes land and get pulled into the testsuite repo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the change to BigInt landed now in V8, I changed this PR accordingly and verified that it fixes test failures. Feel free to merge if you agree with the change.

memory: new WebAssembly.Memory({initial: 1, maximum: 2})
memory64: new WebAssembly.Memory({initial: 1, maximum: 2, index: 'i64'})
};

let handler = {
Expand Down
Loading