Set travis env to Python 3.7 #1151
Conversation
Bikeshed requires 3.7, see speced/bikeshed#321 (comment)
|
Cool! builds after some small fixes in |
ngzhian
changed the title
|
Wow, surprisingly small amount of changes. I was expecting more effort here :) |
|
@sbc100 I know you were doing some more python2 -> python3 conversions, do you see anything else we might want to change? |
document/core/util/mathjax2katex.py
Outdated
| @@ -1,7 +1,7 @@ | |||
| #! /usr/bin/env python | |||
There was a problem hiding this comment.
Think this will be python3 since the travis setup only has python3. But will be useful for local builds. I will make the change.
|
Seems reasonable. |
|
Hm, just noticed that there are a lot of errors in the output that look like "!!! Error processing fragment". See line 5821 here: https://travis-ci.org/github/WebAssembly/spec/builds/666836387?utm_source=github_status&utm_medium=notification. Can you take a look? |
|
Woah woops, should I do a revert of this first? |
|
I don't think it's urgent to fix immediately -- it looks like https://webassembly.github.io/spec still works, and we don't usually have a lot of changes to it. |
|
Sg, I'm looking at it now to figure out what the error messages mean, if I can't figure it out (maybe by lunch?) I'll just send a PR to change this back, then fix it proper later. |
* Set travis env to Python 3.7 Bikeshed requires 3.7, see speced/bikeshed#321 (comment) * Fix import of queue for python3 * Missed 1 more Queue * Update shebangs to python3
Bikeshed requires 3.7, see
speced/bikeshed#321 (comment)
I don't think we can run both 2.7 and 3.7 in travis, we will need to to use 2 different versions of bikeshed, but no way to specific which version of bikeshed in which version of python (could be wrong).