Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node-canary to run interpreter-generated JS tests #1833

Open
wants to merge 1 commit into
base: wasm-3.0
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions .github/workflows/ci-interpreter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ name: CI for interpreter & tests

on:
push:
branches: [ main ]
branches: [ main, wasm-3.0 ]
paths: [ .github/**, interpreter/**, test/** ]

pull_request:
branches: [ main ]
branches: [ main, wasm-3.0 ]
paths: [ .github/**, interpreter/**, test/** ]

# Allows you to run this workflow manually from the Actions tab
Expand All @@ -15,6 +15,8 @@ on:
jobs:
interpreter:
runs-on: ubuntu-latest
env:
NODE_VERSION: 24.0.0-v8-canary20241018c59bfa2926
steps:
- name: Checkout repo
uses: actions/checkout@v2
Expand All @@ -24,13 +26,15 @@ jobs:
ocaml-compiler: 4.14.x
- name: Setup OCaml tools
run: opam install --yes ocamlfind.1.9.5 js_of_ocaml.4.0.0 js_of_ocaml-ppx.4.0.0
- name: Setup Node.js
uses: actions/setup-node@v2
with:
node-version: 20.x
- name: Build interpreter
run: cd interpreter && opam exec make
- name: Setup node canary
run: |
cd $HOME
wget https://nodejs.org/download/v8-canary/v${NODE_VERSION}/node-v${NODE_VERSION}-linux-x64.tar.xz
tar xf node-v${NODE_VERSION}-linux-x64.tar.xz
stat $HOME/node-v${NODE_VERSION}-linux-x64/bin/node
- name: Run tests
# TODO: reactiate node once it supports all of Wasm 3.0
# run: cd interpreter && opam exec make JS=node ci
run: cd interpreter && opam exec make ci
run: |
NODE="$HOME/node-v${NODE_VERSION}-linux-x64/bin/node --wasm-staging"
cd interpreter && opam exec make "JS=$NODE" ci
Loading