Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test files for wabtjs #2371

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Changqing-JING
Copy link
Contributor

Since some bugs are caused by not enough test in wabt.post.js, such as
#2367
#2365

Some test cases of wabt.post.js need to be added to grantee code quality.
One proposal is to migrate the test cases of wabt.js. Because wabt.js is just a npm wrapper of wabt, a lot of user also use wabt from wabt.js by npm install.

But if maintainer have other ideas to test wabt.post.js, I can also try them.

@sbc100
Copy link
Member

sbc100 commented Jan 22, 2024

Can you remind me what downstream project this code is coming from? Can you mention that in the descirption and link to the downstream code?

If we go ahead with this is its probably work working with downstream to migrate these tests such that they can then be removed from downstream (no point testing the same thing in multiple places).

@Changqing-JING
Copy link
Contributor Author

Thank you.
The test are ported from https://github.com/AssemblyScript/wabt.js/blob/main/tests/index.js
Yes, you are right. I can created a PR to remove the duplicate test in wabt.js if this PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants