wasm2c: Cleanup TLS: check for __thread and declare TLS vars only when needed #2488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shravanrn
force-pushed
the
threadlocal-fix
branch
from
dccc152
to
2f693c3
Compare
shravanrn
force-pushed
the
threadlocal-fix
branch
from
2f693c3
to
361d36d
Compare
shravanrn
force-pushed
the
threadlocal-fix
branch
2 times, most recently
from
24d3c1d
to
b4870bb
Compare
shravanrn
changed the title
|
@sbc100 This is now ready for review. Could you please help land this when you have a chance? |
shravanrn
force-pushed
the
threadlocal-fix
branch
from
b4870bb
to
d90ce1a
Compare
sbc100
reviewed
Oct 28, 2024
sbc100
approved these changes
Oct 28, 2024
shravanrn
force-pushed
the
threadlocal-fix
branch
from
d90ce1a
to
8f3b427
Compare
shravanrn
force-pushed
the
threadlocal-fix
branch
from
8f3b427
to
bc93395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WASM_RT_THREAD_LOCALshould use__threadcompiler intrinsic where possible (gcc, clang, icc) to avoid making C11 a hard dependency to compile the wasm2c runtime. This is a necessity for Segue as well as it also uses a thread_local variable.