add preview2_component_type.o to libc.a and libc.so #472
Conversation
This file adds a custom section to each core module linked with wasi-libc. That custom section contains component type information needed by e.g. `wasm-tools component new` to generate a component from the module. It will be required once we start using any part of WASI 0.2.0 directly (vs. via a Preview 1 adapter). In addition, it allows developers to `#include <wasi/preview2.h>` in their code and make use of those APIs directly even if wasi-libc is not using them yet. Signed-off-by: Joel Dice <[email protected]>
| @@ -604,6 +607,10 @@ $(OBJDIR)/%.long-double.pic.o: %.c include_dirs | |||
| @mkdir -p "$(@D)" | |||
| $(CC) $(CFLAGS) -MD -MP -o $@ -c $< | |||
|
|
|||
| $(OBJDIR)/preview2_component_type.pic.o $(OBJDIR)/preview2_component_type.o: $(LIBC_BOTTOM_HALF_SOURCES)/preview2_component_type.o | |||
| @mkdir -p "$(@D)" | |||
| cp $< $@ | |||
There was a problem hiding this comment.
Is copying needed, or would it be enough to just add $(LIBC_BOTTOM_HALF_SOURCES)/preview2_component_type.o to LIBC_OBJS?
There was a problem hiding this comment.
Sorry, I saw this and then forgot to follow up. I'll see if I can eliminate the copy. I think I was concerned adding an already-generated object file to LIBC_OBJS would break a pattern rule somewhere, but we'll see...
There was a problem hiding this comment.
I took another look at this, and I think eliminating the copy would be more trouble than it's worth since the pattern rules for building the .o files for libc.a and libc.so each need their own version (i.e. the .o and the .pic.o, respectively). The file is only 11KB so I don't think the copy adds noticeable bloat to the build.
|
Sounds good. Thanks! |
This file adds a custom section to each core module linked with wasi-libc. That custom section contains component type information needed by e.g.
wasm-tools component newto generate a component from the module. It will be required once we start using any part of WASI 0.2.0 directly (vs. via a Preview 1 adapter). In addition, it allows developers to#include <wasi/preview2.h>in their code and make use of those APIs directly even if wasi-libc is not using them yet.