Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LLVM to 10.x #108

Merged
merged 2 commits into from
Mar 24, 2020
Merged

Update LLVM to 10.x #108

merged 2 commits into from
Mar 24, 2020

Conversation

abrown
Copy link
Collaborator

@abrown abrown commented Mar 24, 2020

No description provided.

sunfishcode
sunfishcode approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sunfishcode sunfishcode merged commit 49e969b into WebAssembly:master Mar 24, 2020
sbc100
sbc100 reviewed Mar 24, 2020
View reviewed changes
Makefile
@@ -164,7 +164,7 @@ build/config.BUILT:
build: build/llvm.BUILT build/wasi-libc.BUILT build/compiler-rt.BUILT build/libcxxabi.BUILT build/libcxx.BUILT build/config.BUILT

strip: build/llvm.BUILT
cd $(PREFIX)/bin; strip clang-9 lld llvm-ar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would imagine that all the clang binaries are symbolic links to each other? I wonder why this wasn't just "clang" from the very beginning?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it actually be something like find $(PREFIX)/bin -type f -executable -exec strip {} \; to get all of the binaries?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, something like that sounds better.

@sbc100
Copy link
Member

sbc100 commented Mar 24, 2020

Hmm.. did llvm 10 actually get released? I guess I missed the announcement.

@sbc100
Copy link
Member

sbc100 commented Mar 24, 2020

Wait.. http://lists.llvm.org/pipermail/llvm-dev/2020-March/140233.html .. that message was sent after this PR.. talk about fast upgrades !

@abrown abrown deleted the llvm-10 branch March 24, 2020 20:49
@abrown
Copy link
Collaborator Author

abrown commented Mar 24, 2020

Wait.. http://lists.llvm.org/pipermail/llvm-dev/2020-March/140233.html .. that message was sent after this PR.. talk about fast upgrades !

Ha! I wasn't even aware... I actually wanted more SIMD functionality and @sunfishcode suggested the release/10.x branch.

@abrown abrown mentioned this pull request Mar 24, 2020
Merged
orestisfl added a commit to orestisfl/wasi-sdk that referenced this pull request May 26, 2020
@orestisfl
Update LLVM submodule branch
7c4aeb9 
The update to LLVM 10.x was done in WebAssembly#108 but the submodule branch was not updated
@orestisfl orestisfl mentioned this pull request May 26, 2020
Merged
orestisfl added a commit to orestisfl/wasi-sdk that referenced this pull request May 27, 2020
@orestisfl
Remove branch from LLVM submodule
236809d 
The update to LLVM 10.x was done in WebAssembly#108 but the submodule branch was
not updated.

As discussed in WebAssembly#136, the branch line is now removed to avoid such
problems.
pchickey pushed a commit that referenced this pull request May 27, 2020
@orestisfl
Remove branch from LLVM submodule (#136)
ef4b45d 
The update to LLVM 10.x was done in #108 but the submodule branch was
not updated.

As discussed in #136, the branch line is now removed to avoid such
problems.
kildom pushed a commit to kildom/clang-wasi-port that referenced this pull request Jul 14, 2021
@mikevoronov @sunfishcode
fix the typo (WebAssembly#108)
c54004f 
* fix the typo
@sbc100 sbc100 mentioned this pull request Sep 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 left review comments

@sunfishcode sunfishcode sunfishcode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abrown @sbc100 @sunfishcode