Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to subclass wasm C++ API classes for the implementor. #161

Merged
merged 28 commits into from
Nov 23, 2020
Merged

Make it possible to subclass wasm C++ API classes for the implementor. #161

merged 28 commits into from
Nov 23, 2020

Commits on Nov 5, 2020

  1. Make it possible to implement the Wasm C++ API using subclasses.

    @nlewycky
    nlewycky committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    2a82d7d View commit details
    Browse the repository at this point in the history

  2. Update wasm-bin for C++ API changes.

    @nlewycky
    nlewycky committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    1a41e0f View commit details
    Browse the repository at this point in the history

  3. WIP. Start updating V8 to the new C++ API.

    @nlewycky
    nlewycky committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    6165f26 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2020

  1. WIP. Continue implementation through ExternType to ExportType. 

    Use some guarantees about standard layout of zero size classes to make a safe reinterpret_cast hierarchy so that the ExternType can find its kind.
    @nlewycky
    nlewycky committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    c8a138a View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2020

  1. Fix own_cast<> to cast to the To type, not to the From type. 

    Fix build of wasm-bin since ExternType::from was removed.
    @nlewycky
    nlewycky committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    51413ad View commit details
    Browse the repository at this point in the history

  2. WIP. First pass through the whole file, excluding Shared<>.

    @nlewycky
    nlewycky committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    c61f484 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2020

  1. Reintroduce template implement and use it, except for the ExternType … 

    …hierarchy.
    @nlewycky
    nlewycky committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    d2e5b1c View commit details
    Browse the repository at this point in the history

  2. Rename "Destroyer" to "destroyer", re-add Table::size_t.

    @nlewycky
    nlewycky committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    4ebbe72 View commit details
    Browse the repository at this point in the history

  3. Update for renaming of Destroyer.

    @nlewycky
    nlewycky committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    31f2b9a View commit details
    Browse the repository at this point in the history

  4. Make destroyer a non-template allowing us to remove own_cast.

    @nlewycky
    nlewycky committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    3e18dbb View commit details
    Browse the repository at this point in the history

  5. Remove make_own<T>(ptr), use own<T>(ptr) instead.

    @nlewycky
    nlewycky committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    bf93f13 View commit details
    Browse the repository at this point in the history

  6. Make these classes instead of structs, since they use public inherita… 

    …nce.
    @nlewycky
    nlewycky committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    3bc9596 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2020

  1. Simplify ExternTypeImpl. Use impl() to cast instead of T::from().

    @nlewycky
    nlewycky committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    3b0598f View commit details
    Browse the repository at this point in the history

  2. Remove use of own_cast<> from wasm-bin too.

    @nlewycky
    nlewycky committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    03ccee2 View commit details
    Browse the repository at this point in the history

  3. Cleanup changes versus master.

    @nlewycky
    nlewycky committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    4f92dd0 View commit details
    Browse the repository at this point in the history

  4. WIP. Implement Shared<> using explicit template specialization.

    @nlewycky
    nlewycky committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    e4fe1b7 View commit details
    Browse the repository at this point in the history

  5. Always free the v8::Persistent<object> handle in the Store.

    @nlewycky
    nlewycky committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    a84c358 View commit details
    Browse the repository at this point in the history

  6. Don't delete v8::PersistenObject ourselves, let the V8 GC do it.

    @nlewycky
    nlewycky committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    43e74c1 View commit details
    Browse the repository at this point in the history

  7. Fix static_assert to work in C++11.

    @nlewycky
    nlewycky committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    99144ae View commit details
    Browse the repository at this point in the history

  8. ValTypeImpl's never destroyed, only a small pool is created on startup.

    @nlewycky
    nlewycky committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    6929ae1 View commit details
    Browse the repository at this point in the history

  9. Simplify this code now that we can implicitly cast own<T>.

    @nlewycky
    nlewycky committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    65a9d63 View commit details
    Browse the repository at this point in the history

  10. Fix bug deleting ExternTypes. Make Shared<Module>::~Shared() non-inline.

    @nlewycky
    nlewycky committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    9f28f9b View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2020

  1. Use structs, remove 'public'.

    @nlewycky
    nlewycky committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    225009c View commit details
    Browse the repository at this point in the history

  2. Add convenience method for creating own<T> without specifying templat… 

    …e parameter.
    @nlewycky
    nlewycky committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    eef1823 View commit details
    Browse the repository at this point in the history

  3. Define the explicit specialization for Shared<Module> in wasm.hh, wit… 

    …h method declarations.
    @nlewycky
    nlewycky committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    8a95d59 View commit details
    Browse the repository at this point in the history

  4. Make a SharedImpl<> that derives from vec<byte_t>.

    @nlewycky
    nlewycky committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    c937d7e View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2020

  1. Forward-declare Shared, then define Shared<Module> after Module.

    @nlewycky
    nlewycky committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    abf9aed View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into use-subclasses

    @nlewycky
    nlewycky committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    3364581 View commit details
    Browse the repository at this point in the history