Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/WDSUS-43 Folder Restructure #1062

Merged

Conversation

khleomix
Copy link
Contributor

@khleomix khleomix commented Sep 4, 2023

Closes WDSUS-43

What type of PR is this? (put an x to all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Link to test

Test locally

Description

  • Remove unused customizer settings
  • Remove mobile menu template
  • Rename src folder to assets

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

N/A

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 Confluence
  • 🙅 no documentation needed

Others

  • 🦮 Is this issue accessible? (Section 508/WCAG 2.0AA)
  • 🙌 Does this issue pass all the linting? (PHPCS, ESLint, SassLint)

[optional] Are there any post-deployment tasks we need to perform?

@khleomix khleomix self-assigned this Sep 4, 2023
@khleomix khleomix changed the base branch from main to release/WDSUS-2-4.0-Theme-Revamp September 4, 2023 20:45
@khleomix khleomix marked this pull request as ready for review September 4, 2023 20:47
Copy link
Contributor

@asharirfan asharirfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@khleomix khleomix merged commit 2645b23 into release/WDSUS-2-4.0-Theme-Revamp Sep 6, 2023
3 checks passed
@khleomix khleomix deleted the feature/WDSUS-43-Folder-restructure branch September 6, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants