Phg/query params disamb #1127
Phg/query params disamb #1127
Conversation
core/src/main/kotlin/org/evomaster/core/output/naming/RestActionTestCaseNamingStrategy.kt
Outdated
Show resolved
Hide resolved
| * The filter call ensures that we are only performing this disambiguation when there's only one individual that | ||
| * differs and the list of query params is not empty. | ||
| */ | ||
| private fun checkForQueryParams(duplicatedIndividuals: MutableSet<EvaluatedIndividual<*>>): Map<EvaluatedIndividual<*>, String> { |
There was a problem hiding this comment.
i guess could be specified <RestIndividual instead of <*>?
There was a problem hiding this comment.
Tried doing so, the Kotlin type system didn't like it much
| .filter { it.value.size == 1 && it.key.isNotEmpty()} | ||
| .mapNotNull { entry -> | ||
| val eInd = entry.value[0] | ||
| duplicatedIndividuals.remove(eInd) |
There was a problem hiding this comment.
why this? this is a side effect on the input list. quite confusing, considering that the name of the function is check. also, this is the same datastructure used on line 118 at the beginning of stream operations (althugh these ones are eagerly evaluated), which complicates the understanding of the function. this needs refactoring/simplification
There was a problem hiding this comment.
as rule of thumb, side effects on inputs data structures should be avoided, unless explicitely clarified in the method name (somehow)
There was a problem hiding this comment.
I've just pushed a draft on a possible solution. It transfers the responsibility of removing the solved duplicates to a specific function.
The downside is the duplicate removal happens twice:
- in the
resolveAmbiguitiesfunction where the local working copy has the resolved duplicates removed - in the outer loop which triggers the resolution in NumberedTestCaseNamingStrategy.
However, this downside could be an advantage if we decide that all ambiguity solvers should be executed for resolution. It could even be tested for the experimentation: "do you like this naming where it only solves by one particular parameter or do you want the whole enchilada?".
Let me know what you think. Once we decide on this I'll also extract the groupBy sections of the solvers to more clearly named methods
duplicatedIndividuals: MutableSet, either no more disambiguation takes place (no individuals are removed from the set) or eventually all individuals are disambigauted (the set size is now 0 and the next iteration will have the same size)