This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make LibWebRTCRtpSenderBackend own its libwebrtc RTP sender backend
https://bugs.webkit.org/show_bug.cgi?id=189270 Reviewed by Eric Carlson. Previously, the libwebrtc senders were owned in LibWebRTCMediaEndpoint. This patch makes them be owned by LibWebRTCRtpSenderBackend. This simplifies the implementation of RTCRtpSender::getParameters. This will help simplify the implementation of RTCRtpSender::replaceTrack. removeTrack is also refactored so that LibWebRTCMediaEndpoint directly uses libwebrtc constructs and not WebCore libwebrtc-agnostic ones. No change of behavior. * Modules/mediastream/PeerConnectionBackend.h: (WebCore::PeerConnectionBackend::removeTrack): (WebCore::PeerConnectionBackend::notifyRemovedTrack): Deleted. * Modules/mediastream/RTCPeerConnection.cpp: (WebCore::RTCPeerConnection::removeTrack): * Modules/mediastream/RTCRtpSender.cpp: (WebCore::RTCRtpSender::getParameters): * Modules/mediastream/RTCRtpSender.h: (WebCore::RTCRtpSender::backend): * Modules/mediastream/RTCRtpSenderBackend.h: * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::LibWebRTCMediaEndpoint::addTrack): (WebCore::LibWebRTCMediaEndpoint::removeTrack): (WebCore::LibWebRTCMediaEndpoint::doCreateOffer): (WebCore::LibWebRTCMediaEndpoint::stop): (WebCore::LibWebRTCMediaEndpoint::shouldOfferAllowToReceiveAudio const): Deleted. (WebCore::LibWebRTCMediaEndpoint::shouldOfferAllowToReceiveVideo const): Deleted. (WebCore::LibWebRTCMediaEndpoint::getRTCRtpSenderParameters): Deleted. * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h: * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp: (WebCore::backendFromRTPSender): (WebCore::LibWebRTCPeerConnectionBackend::addTrack): (WebCore::LibWebRTCPeerConnectionBackend::addTransceiver): (WebCore::LibWebRTCPeerConnectionBackend::removeTrack): (WebCore::LibWebRTCPeerConnectionBackend::shouldOfferAllowToReceive const): (WebCore::LibWebRTCPeerConnectionBackend::notifyRemovedTrack): Deleted. (WebCore::LibWebRTCPeerConnectionBackend::getParameters const): Deleted. * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h: * Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.cpp: (WebCore::LibWebRTCRtpSenderBackend::getParameters const): * Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@235649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
1 parent
b560616
commit e70478b
Showing
12 changed files
with
112 additions
and
88 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,51 @@ | ||
2018-09-04 Youenn Fablet <[email protected]> | ||
|
||
Make LibWebRTCRtpSenderBackend own its libwebrtc RTP sender backend | ||
https://bugs.webkit.org/show_bug.cgi?id=189270 | ||
|
||
Reviewed by Eric Carlson. | ||
|
||
Previously, the libwebrtc senders were owned in LibWebRTCMediaEndpoint. | ||
This patch makes them be owned by LibWebRTCRtpSenderBackend. | ||
This simplifies the implementation of RTCRtpSender::getParameters. | ||
This will help simplify the implementation of RTCRtpSender::replaceTrack. | ||
|
||
removeTrack is also refactored so that LibWebRTCMediaEndpoint directly uses libwebrtc constructs and not WebCore libwebrtc-agnostic ones. | ||
|
||
No change of behavior. | ||
|
||
* Modules/mediastream/PeerConnectionBackend.h: | ||
(WebCore::PeerConnectionBackend::removeTrack): | ||
(WebCore::PeerConnectionBackend::notifyRemovedTrack): Deleted. | ||
* Modules/mediastream/RTCPeerConnection.cpp: | ||
(WebCore::RTCPeerConnection::removeTrack): | ||
* Modules/mediastream/RTCRtpSender.cpp: | ||
(WebCore::RTCRtpSender::getParameters): | ||
* Modules/mediastream/RTCRtpSender.h: | ||
(WebCore::RTCRtpSender::backend): | ||
* Modules/mediastream/RTCRtpSenderBackend.h: | ||
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: | ||
(WebCore::LibWebRTCMediaEndpoint::addTrack): | ||
(WebCore::LibWebRTCMediaEndpoint::removeTrack): | ||
(WebCore::LibWebRTCMediaEndpoint::doCreateOffer): | ||
(WebCore::LibWebRTCMediaEndpoint::stop): | ||
(WebCore::LibWebRTCMediaEndpoint::shouldOfferAllowToReceiveAudio const): Deleted. | ||
(WebCore::LibWebRTCMediaEndpoint::shouldOfferAllowToReceiveVideo const): Deleted. | ||
(WebCore::LibWebRTCMediaEndpoint::getRTCRtpSenderParameters): Deleted. | ||
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h: | ||
* Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp: | ||
(WebCore::backendFromRTPSender): | ||
(WebCore::LibWebRTCPeerConnectionBackend::addTrack): | ||
(WebCore::LibWebRTCPeerConnectionBackend::addTransceiver): | ||
(WebCore::LibWebRTCPeerConnectionBackend::removeTrack): | ||
(WebCore::LibWebRTCPeerConnectionBackend::shouldOfferAllowToReceive const): | ||
(WebCore::LibWebRTCPeerConnectionBackend::notifyRemovedTrack): Deleted. | ||
(WebCore::LibWebRTCPeerConnectionBackend::getParameters const): Deleted. | ||
* Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h: | ||
* Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.cpp: | ||
(WebCore::LibWebRTCRtpSenderBackend::getParameters const): | ||
* Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h: | ||
|
||
2018-09-04 Wenson Hsieh <[email protected]> | ||
|
||
Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.