Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASSERT_WITH_SECURITY_IMPLICATION FAILED: !object || object->isMeter() in WebCore::toRenderMeter #15

Closed
renatahodovan opened this issue Jun 24, 2013 · 3 comments
Closed

ASSERT_WITH_SECURITY_IMPLICATION FAILED: !object || object->isMeter() in WebCore::toRenderMeter #15

renatahodovan opened this issue Jun 24, 2013 · 3 comments

Comments

@renatahodovan
Copy link

The condition ASSERT_WITH_SECURITY_IMPLICATION(!object || object->isMeter()) in WebCore::toRenderMeter fails on the following test:

`



`

This assertion check was introduced in r140640. According to the comments probably we made a bad cast mistake somewhere. Furthermore it seems that the problem is nix-specific.
@jeez
Copy link
Member

jeez commented Jun 24, 2013

At a first glance, I couldn't find we using it, but I guess @dakerfp knows about it better.

@qrwteyrutiyoup
Copy link
Member

This should solve it https://gist.github.com/qrwteyrutiyoup/5850304, but the guys are having a holiday today, so probably it won' t be reviewed until tomorrow.

qrwteyrutiyoup added a commit that referenced this issue Jun 25, 2013
@qrwteyrutiyoup
Return early if RenderObject is not a meter, in RenderThemeNix::paint…
ffa508e 
…Meter()

We return true if that's the case, like other ports do. This avoids a problem
with ASSERT_WITH_SECURITY_IMPLICATION FAILED: !object || object->isMeter() in
WebCore::toRenderMeter, as reported in Issue #15 on GitHub.

Reviewed by: Daker Fernandes Pinheiro
@qrwteyrutiyoup
Copy link
Member

Thanks for reporting this problem. Closing the issue as ffa508e has landed.

This was referenced Jul 15, 2013
Open
Open
Open
This was referenced Aug 23, 2013
Closed
Open
@lauromoura lauromoura mentioned this issue Aug 30, 2013
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@qrwteyrutiyoup @jeez @renatahodovan