Buildfix if NIX is built with libcurl #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When NIX is built with libcurl network backend then in some cases the glib.h is not included. This is also such a case. Just added a simple glib.h include to the file.
|
If it is a reappearing issue than probably we should add the include into some root place like config.h? |
|
It's not really that frequent, this is the first such issue in ~3 months. I don't think putting the include into the config.h is a good idea, IMHO being a bit more explicit with the includes is better. |
|
I agree with @elecro , better being a bit more explicit on include files. |
|
Landed, this was an issue independent from libcurl, this file uses a glib function but didn't include the glib header directly :-/ |
This was referenced Jul 15, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When NIX is built with libcurl network backend then in some cases
the glib.h is not included. This is also such a case. Just added a
simple glib.h include to the file.