Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using @nobles/hashes #162

Closed
wants to merge 22 commits into from
Closed

Using @nobles/hashes #162

wants to merge 22 commits into from

Conversation

AlexAndrei98
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f4e4400) 81.22% compared to head (91f0690) 81.42%.
Report is 15 commits behind head on development.

Files Patch % Lines
src/ready.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #162      +/-   ##
===============================================
+ Coverage        81.22%   81.42%   +0.20%     
===============================================
  Files               46       46              
  Lines             4139     4141       +2     
  Branches          1023     1030       +7     
===============================================
+ Hits              3362     3372      +10     
+ Misses             745      737       -8     
  Partials            32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@lenkan lenkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice to be able to replace the blake3 dependency! I saw an issue with the lock-file here though. Not sure what would have caused it, but it seems to be a known issue in npm under certain conditions.

package-lock.json Outdated Show resolved Hide resolved
src/ready.ts Outdated Show resolved Hide resolved
lenkan and others added 15 commits December 4, 2023 10:40
convert remaining integration-scripts to tests
address comments from Daniel
…credential grant.

Sample in `single-issuer-holder.test.ts` of using data from credentials/list to create a GRANT for presenting a held credential.
Changed workflow for integration tests to pull image every time since our plan is to overwrite the dev tags on the images for development builds for KERIA / KERIpy
Add credential presentation from held credential to verifier
@lenkan
Copy link
Collaborator

lenkan commented Dec 7, 2023

@AlexAndrei98 I think this just needs a rebase to verify the integration tests are working.

@AlexAndrei98
Copy link
Contributor Author

@AlexAndrei98 I think this just needs a rebase to verify the integration tests are working.

@lenkan I tried to rebase from development 🤞🏽

@pfeairheller pfeairheller self-requested a review December 7, 2023 15:21
@pfeairheller
Copy link
Member

The commit history is a mess, could you please squash this so we can review it properly?

@AlexAndrei98
Copy link
Contributor Author

closing in favor of #174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants