Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build issue due to missing autoreconf, fix quoting in environment… #3169

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

ogra1
Copy link
Contributor

@ogra1 ogra1 commented Sep 30, 2024

… variables (new snapcraft is a bit stricter here)

… variables (new snapcraft is a bit stricter here)
@benfrancis benfrancis merged commit 0bb2ccd into WebThingsIO:master Sep 30, 2024
3 checks passed
@dilyn-corner
Copy link
Contributor

FYI this may have just been a duplicate of this.

@benfrancis
Copy link
Member

@mr-cal Has canonical/snapcraft#5051 made it into the stable channel of the snapcraft snap yet?

When I try to run snapcraft without this patch (at f45dd83) using snapcraft 8.4.2 (released on the stable channel today) I still get an error:

ad snapcraft.yaml content:                                                    
- Value error, value must be a list of Annotated: [{'npm_config_unsafe_perm': True}, {'NODE_ENV': 'dev'}, {'CPPFLAGS': '$CPPFLAGS -DPNG_ARM_NEON_OPT=0'}] (in field 'parts.webthings-gateway.build-environment')                               
Full execution log: '/home/tola/.local/state/snapcraft/log/snapcraft-20241009-182629.208188.log'      

I assume the error is due to a change in snapcraft because the snap had previously been building locally at f45dd83 (before this patch) with an earlier version of snapcraft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants