Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throwing exceptions without descriptions #408

Closed
TonyMarston opened this issue May 29, 2023 · 1 comment
Closed

Throwing exceptions without descriptions #408

TonyMarston opened this issue May 29, 2023 · 1 comment

Comments

@TonyMarston
Copy link

Is your feature request related to a problem? Please describe.
After connecting to a mailbox and then attempting to call $client->getFolder('INBOX') I get the following error:
Uncaught exception from Webklex\PHPIMAP\Exceptions\ImapServerErrorException in vendor\webklex\php-imap\src\Connection\Protocols\ImapProtocol.php, line=306. I stopped at than line with my debugger to see the contents of $tokens contained the message "BAD User is authenticated but not connected." This is FAR more meaningful than simply the name of the exception.

Describe the solution you'd like
I consider it to be bad form to throw an exception without an error description. Please include proper descriptions when throwing errors as I HATE having to debug somebody else's code.

Describe alternatives you've considered
none

Additional context
none

@Webklex
Copy link
Owner

Webklex commented Jun 23, 2023

Hi @TonyMarston ,
many thanks for your report and suggestion. Please feel welcome to fix what ever bothers you and invited to share it with others via pull requests.
That's the great power of open source :)

Best regards and happy coding,

@Webklex Webklex closed this as completed Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants