Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split out docker build #2780

Merged
merged 1 commit into from
Nov 5, 2024
Merged

feat: split out docker build #2780

merged 1 commit into from
Nov 5, 2024

Conversation

nijel
Copy link
Member

@nijel nijel commented Nov 5, 2024

Proposed changes

  • use base images built separately that contain all system dependencies
  • use multistage build to avoid devel deps in the final image

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel nijel force-pushed the multistage branch 5 times, most recently from aac4435 to 2f3c673 Compare November 5, 2024 12:26
- use base images built separately that contain all system dependencies
- use multistage build to avoid devel deps in the final image
- this also reduces pressure on GitHub cache, see WeblateOrg#2589
@nijel nijel merged commit 5bf9347 into WeblateOrg:main Nov 5, 2024
36 checks passed
@nijel nijel deleted the multistage branch November 5, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant