[Tune] Do not warn in BayesOpt w/ Uniform sampler (ray-project#30350)

BayesOpt supports only uniform sampling, but we erroneously warn when the Uniform sampler is used (as opposed to no sampler at all). This PR fixes that issue. Signed-off-by: Antoni Baum <[email protected]> Signed-off-by: Weichen Xu <[email protected]>
WeichenXu123 · Dec 19, 2022 · db833d8 · db833d8
1 parent 31c7311
commit db833d8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/doc/source/tune/examples/bayesopt_example.ipynb b/doc/source/tune/examples/bayesopt_example.ipynb
@@ -280,9 +280,7 @@
      "name": "stderr",
      "output_type": "stream",
      "text": [
-      "Function checkpointing is disabled. This may result in unexpected behavior when using checkpointing features or certain schedulers. To enable, set the train function arguments to be `func(config, checkpoint_dir=None)`.\n",
-      "BayesOpt does not support specific sampling methods. The Uniform sampler will be dropped.\n",
-      "BayesOpt does not support specific sampling methods. The Uniform sampler will be dropped.\n"
+      "Function checkpointing is disabled. This may result in unexpected behavior when using checkpointing features or certain schedulers. To enable, set the train function arguments to be `func(config, checkpoint_dir=None)`.\n"
      ]
     },
     {

diff --git a/python/ray/tune/search/bayesopt/bayesopt_search.py b/python/ray/tune/search/bayesopt/bayesopt_search.py
@@ -5,7 +5,7 @@
 from typing import Dict, List, Optional, Tuple, Any, TYPE_CHECKING
 
 from ray.tune.result import DEFAULT_METRIC
-from ray.tune.search.sample import Domain, Float, Quantized
+from ray.tune.search.sample import Domain, Float, Quantized, Uniform
 from ray.tune.search import (
     UNRESOLVED_SEARCH_SPACE,
     UNDEFINED_METRIC_MODE,
@@ -419,7 +419,9 @@ def resolve_value(domain: Domain) -> Tuple[float, float]:
                 sampler = sampler.get_sampler()
 
             if isinstance(domain, Float):
-                if domain.sampler is not None:
+                if domain.sampler is not None and not isinstance(
+                    domain.sampler, Uniform
+                ):
                     logger.warning(
                         "BayesOpt does not support specific sampling methods. "
                         "The {} sampler will be dropped.".format(sampler)