Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model_saving_strategy=best does not work #514

Merged
merged 1 commit into from
Sep 22, 2024
Merged

model_saving_strategy=best does not work #514

merged 1 commit into from
Sep 22, 2024

Conversation

WenjieDu
Copy link
Owner

What does this PR do?

  1. fixing Model saving bug #464;

Before submitting

  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.

@coveralls
Copy link
Collaborator

coveralls commented Sep 19, 2024

Pull Request Test Coverage Report for Build 10932122525

Details

  • 39 of 39 (100.0%) changed or added relevant lines in 39 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 83.346%

Files with Coverage Reduction New Missed Lines %
pypots/nn/modules/fedformer/layers.py 2 45.99%
pypots/cli/doc.py 3 82.28%
Totals Coverage Status
Change from base Build 10833804335: -0.02%
Covered Lines: 11195
Relevant Lines: 13432

💛 - Coveralls

@WenjieDu WenjieDu merged commit d8ade79 into dev Sep 22, 2024
9 checks passed
@WenjieDu WenjieDu deleted the (fix)model_saving branch September 25, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants