Add Options menu and Combo Configuration Menu #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diwo
changed the title
|
@WerWolv this one is ready now, depends on WerWolv/libtesla#23 |
|
Note that there's no safeguard against assigning stupid key combos like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preview of the combo config UI. It cannot compile against libtesla@master since the lib is currently missing APIs to allow Gui to capture
keysHeldand to update combo keys. This PR also does not include changes to existing UI elements to access this new UI.The combo config UI asks the user to hold down the new key combo for 2.5 seconds. The user then has to release all the keys, and then input the new combo again to confirm the change. The user can leave the UI without changing the combo by pressing KEY_PLUS twice.
Screenshots:
https://imgur.com/yZ12kx6
https://imgur.com/X22zqBL
https://imgur.com/BNd9JuL