Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The game cannot be played on iPhone #37

Open
Wgil opened this issue Oct 6, 2018 · 4 comments
Open

The game cannot be played on iPhone #37

Wgil opened this issue Oct 6, 2018 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed react

Comments

@Wgil
Copy link
Owner

Wgil commented Oct 6, 2018

The game cannot be played on iPhone

When you start the game on a mobile phone in portrait mode, you can see a screen indicating that you have to rotate your phone to be able to play the game.

Users have reported that opening the game on an Iphone, they just see a blank screen. 😟

To solve this issue, you first have to make a little research to know exactly which browsers are affected🧐. Currently, we are using the Screen.orientation property to detect the orientation device and the orientationchange event to hide/show the Game. You can find this logic in src/containers/Orientation.js.

I am not pretty sure how to approach this issue, probably we can create a polyfill or simply get rid of Screen.orientation and make use of resize and make it work in certain breakpoint Any suggestion would be appreciated. 🙏

@Wgil Wgil added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers react Hacktoberfest labels Oct 6, 2018
@bagshik
Copy link

bagshik commented Oct 6, 2018

Hey man, I was looking for a React project to contribute to. I can give this a try 👌

@Wgil
Copy link
Owner Author

Wgil commented Oct 6, 2018

Of course you can bro! Take a look to it and feel free to ask if you have any questions. Don't forget to check out the contributing guidelines and have a happy coding :) @bagshik

@bagshik
Copy link

bagshik commented Oct 6, 2018

I definitely will, thanks man. Should I branch off from 'development'?

@Wgil
Copy link
Owner Author

Wgil commented Oct 6, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed react
Projects
None yet
Development

No branches or pull requests

2 participants