Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Cut Players after Rubber #268

Merged
merged 21 commits into from
Nov 24, 2022
Merged

Conversation

Segelzwerg
Copy link
Contributor

Breaking Changes:

  • Removal of random distribution in rubber.

@Segelzwerg Segelzwerg self-assigned this Nov 11, 2022
@Segelzwerg Segelzwerg added the python Pull requests that update Python code label Nov 11, 2022
@Segelzwerg Segelzwerg linked an issue Nov 11, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #268 (0e653bf) into main (b13c4c1) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
- Coverage   97.22%   97.21%   -0.02%     
==========================================
  Files          28       29       +1     
  Lines         792      825      +33     
==========================================
+ Hits          770      802      +32     
- Misses         22       23       +1     
Impacted Files Coverage Δ
whist_core/game/rubber.py 100.00% <ø> (ø)
whist_core/session/distribution.py 100.00% <100.00%> (ø)
whist_core/session/matcher.py 98.11% <100.00%> (-1.89%) ⬇️
whist_core/session/table.py 100.00% <100.00%> (ø)
whist_core/session/userlist.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Segelzwerg <[email protected]>
Signed-off-by: Segelzwerg <[email protected]>
Signed-off-by: Segelzwerg <[email protected]>
@Segelzwerg Segelzwerg linked an issue Nov 11, 2022 that may be closed by this pull request
@Segelzwerg Segelzwerg marked this pull request as ready for review November 11, 2022 19:31
@Dichloromethane
Copy link

🤮

@Whist-Team Whist-Team deleted a comment from Dichloromethane Nov 11, 2022
@Segelzwerg
Copy link
Contributor Author

vomiting_face

Please retain from trolling, but constructive contributions are highly appreciated. If you don't like it, you can create your own PR.

@iTitus iTitus merged commit 0073058 into main Nov 24, 2022
@iTitus iTitus deleted the feature/cut_players_after_rubber branch November 24, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TEST: equals test for matcher FEATURE: Cut players after rubber
3 participants