Allow wildcard redirect to domains #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harnash
requested changes
Jul 6, 2021
abador
force-pushed
the
allow-wildcard-redirect-to-domains
branch
from
e640e7d
to
b9c8c66
Compare
harnash
approved these changes
Jul 12, 2021
abador
force-pushed
the
allow-wildcard-redirect-to-domains
branch
from
b9c8c66
to
e558525
Compare
abador
force-pushed
the
allow-wildcard-redirect-to-domains
branch
from
e558525
to
67d79ef
Compare
|
Created for upstream: ory#1528 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
issue #943
Proposed changes
Checklist
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further comments
I've implemented wildcards using existing config and almost the same logic. It supports scheme configuration like any other domain wildcard. Domains are verified(also via a public suffix: golang.org/x/net/publicsuffix) during config parse and if we try to wildcard all domains eg: http://* it will be filtered out as an invalid wildcard